Merged
Conversation
hisonghy
reviewed
Jul 21, 2025
src/main/java/com/ject/studytrip/mission/application/facade/MissionFacade.java
Show resolved
Hide resolved
src/main/java/com/ject/studytrip/mission/application/service/MissionService.java
Show resolved
Hide resolved
src/main/java/com/ject/studytrip/mission/domain/policy/MissionPolicy.java
Show resolved
Hide resolved
Contributor
피그마를 확인해보니, 미션에 |
Contributor
Author
확인했습니다. 미션 엔티티 수정하고, 미션 생성/미션 수정 비즈니스 로직도 리팩토링해서 다시 올리겠습니다. |
Contributor
Author
|
@songhyeonpk 여행, 스탬프, 미션에서 사용되는 필드 이름은 |
Contributor
지금 수정하게 되면 수정할 내용이 많아질 것 같아서 우선 |
chaiminwoo0223
force-pushed
the
feature/32
branch
from
16f12b4 to
2c6252d
Compare
hisonghy
approved these changes
Jul 23, 2025
Contributor
hisonghy
left a comment
hisonghy
left a comment
There was a problem hiding this comment.
고생하셨습니다! 커밋 확인 후 병합부탁드려요
* feat: Mission에 update, updateMissionOrder, updateDeletedAt 메서드 추가 * feat: Mission에 memo 필드 추가 * feat: MissionFactory 구현 * feat: MissionErrorCode 추가 * feat: MissionRepository에 findAllByIdIn, existsByStampIdAndMissionOrderAndDeletedAtIsNull, save 등 메서드 추가 * feat: MemberService에 createMission, updateMissionNameAndMemo, updateMissionOrders, deleteMission 등 메서드 추가 * feat: MissionPolicy 구현 * feat: MissionFacade 구현 * feat: CreateMissionRequest, UpdateMissionRequest, UpdateMissionOrderRequest 추가 * feat: CreateMissionResponse 추가 * feat: MissionController 구현 * refactor: StampService에서 updateStampOrders, updateStampOrdersByTripCategoryChange 메서드로 이름 변경 * test: MissionFixture, CreateMissionRequestFixture, UpdateMissionRequestFixture, UpdateMissionOrderRequestFixture 추가 * test: MissionServiceTest 단위 테스트 추가 * test: MissionTestHelper 추가 * test: MissionControllerIntegrationTest 통합 테스트 추가
chaiminwoo0223
force-pushed
the
feature/32
branch
from
2ece507 to
ef3bb61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 작업 내용 및 특이사항
✅ 미션 생성 API
MissionPolicy를 통해 중복되지 않도록 검증합니다.MissionFactory가 담당합니다.CreateMissionResponse로 응답합니다.✅ 미션 수정 API
Mission.update()를 통해 수행합니다.✅ 미션 순서 변경 API
MissionPolicy.validateMissionOrders()에서 검증합니다.✅ 미션 삭제 API
Mission.updateDeletedAt()메서드를 통해 처리되며, 실제로 DB에서 제거되지는 않습니다.✅ 미션 목록 조회 API
✅ 요청(Request) DTO
CreateMissionRequest: 미션 생성 요청UpdateMissionRequest: 미션 수정 요청UpdateMissionOrderRequest: 미션 순서 일괄 수정 요청✅ 응답(Response) DTO
CreateMissionResponse: 미션 생성 결과 응답LoadMissionInfoResponse: 미션 목록 조회 응답✅ 예외 처리
MissionErrorCode를 정의✅ 테스트
MissionServiceTest단위 테스트 추가MissionFixture추가CreateMissionRequestFixture,UpdateMissionRequestFixture,UpdateMissionOrderRequestFixture추가MissionTestHelper추가MissionControllerIntegrationTest통합 테스트 추가🌱 관련 이슈
🔍 참고사항
📚 기타
StampService: updateStampOrders, updateStampOrdersByTripCategoryChange 메서드로 이름 변경src/main/java/com/ject/.DS_Store,src/test/java/com/ject/.DS_Store삭제